Skip to content

Don't allow JSXNamespacedName to chain#10366

Merged
jridgewell merged 1 commit intobabel:masterfrom
jridgewell:jsx-namespace-member
Aug 26, 2019
Merged

Don't allow JSXNamespacedName to chain#10366
jridgewell merged 1 commit intobabel:masterfrom
jridgewell:jsx-namespace-member

Conversation

@jridgewell
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Eg, namespace:foo.bar used to parse but is invalid in the spec.

Also, allow JSXNamespacedName in the JSXOpeningElement/JSXClosingElement builders.

Eg, `namespace:foo.bar` used to parse but is invalid in the [spec](https://facebook.github.io/jsx/).

Also, allow `JSXNamespacedName` in the `JSXOpeningElement`/`JSXClosingElement` builders.
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11396/

@JLHwung JLHwung added area: jsx PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Aug 26, 2019
@jridgewell jridgewell merged commit 1664cce into babel:master Aug 26, 2019
@jridgewell jridgewell deleted the jsx-namespace-member branch August 26, 2019 17:16
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: jsx outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants