Skip to content

Flow enums parsing#10344

Merged
nicolo-ribaudo merged 7 commits intobabel:masterfrom
gkz:parse-enums
Oct 29, 2019
Merged

Flow enums parsing#10344
nicolo-ribaudo merged 7 commits intobabel:masterfrom
gkz:parse-enums

Conversation

@gkz
Copy link
Copy Markdown
Contributor

@gkz gkz commented Aug 15, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes (added behind optional flag)
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Flow is working on adding an optional (and by default off) enums feature, gated by the experimental.enums Flowconfig flag. Parsing was implemented in the Flow Parser 1.5 months ago (facebook/flow@e3ee40c).

Here, we add support for parsing Flow Enums in the Flow babel-parser plugin, also gated by an option, enums. This brings Babel's Flow parsing in line with Flow Parser's.

Here are some examples:

enum E {
  A,
  B,
}

enum E {
  A = 1,
  B = 2,
}

For more information, see this document: https://github.com/gkz/enums

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Aug 15, 2019 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11410/

@buildsize
Copy link
Copy Markdown

buildsize bot commented Aug 15, 2019 •
edited
Loading

File name Previous Size New Size Change
babel-preset-env.js 2.36 MB 2.39 MB 27.7 KB (1%)
babel-preset-env.min.js 1.35 MB 1.36 MB 13.47 KB (1%)
babel.js 2.91 MB 2.94 MB 27.88 KB (1%)
babel.min.js 1.61 MB 1.62 MB 13.58 KB (1%)

nicolo-ribaudo
nicolo-ribaudo reviewed Aug 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can enums be exported? Is this valid?

export default enum {}

@nicolo-ribaudo nicolo-ribaudo added area: flow pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories labels Aug 19, 2019
@existentialism
Copy link
Copy Markdown
Member

existentialism commented Aug 20, 2019

/cc: @babel/flow

@gkz
Copy link
Copy Markdown
Contributor Author

gkz commented Aug 26, 2019

Thank you for reviewing @nicolo-ribaudo! I will update/respond this week

@gkz
Copy link
Copy Markdown
Contributor Author

gkz commented Aug 29, 2019

Will add support for parsing export of enums

@gkz
Copy link
Copy Markdown
Contributor Author

gkz commented Aug 30, 2019

I have updated the pull request as per comments

@nicolo-ribaudo nicolo-ribaudo added this to the v7.7.0 milestone Sep 17, 2019
nicolo-ribaudo
nicolo-ribaudo reviewed Sep 24, 2019
View reviewed changes
@nicolo-ribaudo nicolo-ribaudo self-requested a review October 9, 2019 21:18
nicolo-ribaudo
nicolo-ribaudo reviewed Oct 9, 2019
View reviewed changes
@gkz gkz requested a review from nicolo-ribaudo October 15, 2019 23:05
@gkz
Copy link
Copy Markdown
Contributor Author

gkz commented Oct 15, 2019 •
edited
Loading

Not sure exactly the purpose of the "request a review" button on GitHub, but I clicked it. Actually looking at this it doesn't look like PRs need to be "approved" before they are merged, so feel free to ignore the request (if you have no additional comments)

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Oct 15, 2019

We need to ✔️ to merge a PR (and I won't merge it until the 7.7.0 release anyway)

@nicolo-ribaudo nicolo-ribaudo added the PR: Needs Review A pull request awaiting more approvals label Oct 17, 2019
JLHwung
JLHwung reviewed Oct 18, 2019
View reviewed changes
JLHwung
JLHwung reviewed Oct 18, 2019
View reviewed changes
JLHwung
JLHwung reviewed Oct 18, 2019
View reviewed changes
@JLHwung JLHwung added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: Needs Review A pull request awaiting more approvals labels Oct 22, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit ec3345b into babel:master Oct 29, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 29, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Milestone

v7.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gkz @babel-bot @existentialism @nicolo-ribaudo @JLHwung