Fix flow comments plugin issues#10329
Merged
nicolo-ribaudo merged 5 commits intobabel:masterfrom Aug 14, 2019
ziadkh0:fix-flow-comments-plugin-issues
Merged
Fix flow comments plugin issues#10329nicolo-ribaudo merged 5 commits intobabel:masterfrom ziadkh0:fix-flow-comments-plugin-issues
nicolo-ribaudo merged 5 commits intobabel:masterfrom
ziadkh0:fix-flow-comments-plugin-issues
Conversation
Contributor
Author
|
Does anyone know why is the CI build failing? |
Member
|
Yeah ignore CircleCI, it should be fixed by 0519650 |
Contributor
Author
|
@nicolo-ribaudo Thank you |
Member
|
Yeah it would be appreciated but not needed |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11323/ |
JLHwung
reviewed
Aug 13, 2019
...ow-comments/test/fixtures/flow-comments/class-type-parameter-extends-type-parameter/input.js
Outdated
Show resolved
Hide resolved
JLHwung
approved these changes
Aug 14, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues in
plugin-transform-flow-commentswhere some comments might get lost or have their position changed.And add support for correctly handling
extendskeyword in theclassdeclaration.