Add a builder definition including name for tsTypeParameter#10319
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Aug 15, 2019
deificx:10317-tsTypeParameter-should-take-a-name
Merged
Add a builder definition including name for tsTypeParameter#10319nicolo-ribaudo merged 1 commit intobabel:masterfrom deificx:10317-tsTypeParameter-should-take-a-name
nicolo-ribaudo merged 1 commit intobabel:masterfrom
deificx:10317-tsTypeParameter-should-take-a-name
Conversation
|
|
||
| defineType("TSTypeParameter", { | ||
| visitor: ["constraint", "default"], | ||
| visitor: ["constraint", "default", "name"], |
Member
There was a problem hiding this comment.
Only nodes can be visited, so we can't add name to visitor.
You can define builder: ["constraint", "default", "name"], instead.
nicolo-ribaudo
approved these changes
Aug 14, 2019
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
CircleCI failure is unrelated
JLHwung
approved these changes
Aug 15, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nameto the visitor field forTSTypeParameter, this is a required field but since it is not listed here the assert fails rendering the function useless, since it cannot be called with either 2 or 3 arguments.Documentation: I found this when trying to run all the t.* builder functions, but my generation "fails" here because it doesn't look like these arguments are required, they are (which has been corrected in the current master). So I will need to re-run that generation once that fix is available.