Adds note about two approval policy to PR template#10313
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Aug 12, 2019
Merged
Adds note about two approval policy to PR template#10313nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo merged 2 commits intobabel:masterfrom
Conversation
xtuc
approved these changes
Aug 9, 2019
Contributor
Author
|
Shoot! Should've added |
nicolo-ribaudo
approved these changes
Aug 9, 2019
Member
|
I think I wrote some stuff before around this https://github.com/babel/babel/wiki/Maintaining-Babel#merging but yeah the general case is 2, unless it's more of a typo thing (mostly for the website), I guess master is failing due to test fixtures (I assume related to data from compat type stuff) |
JLHwung
approved these changes
Aug 9, 2019
Because, although two approvals is the general case, some PRs maybe merged with more or fewer approvals
Contributor
Author
|
I wasn't aware of that documentation. Just added a qualifier to the proposal in light of that |
Member
|
Should be fine to merge if master is ok |
nicolo-ribaudo
approved these changes
Aug 12, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've sometimes noticed some folks getting confused about Babel's two approval policy. From the Contributor point of view, the PR seems stale after getting the first approval.
This adds a comment to the PR template with the goal of surfacing the policy and avoiding confusion.