[fix] jsx helper calls order#10307
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Aug 8, 2019
Sinewyk:fix_jsx_help_default_props_after_children
Merged
[fix] jsx helper calls order#10307nicolo-ribaudo merged 1 commit intobabel:masterfrom Sinewyk:fix_jsx_help_default_props_after_children
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Sinewyk:fix_jsx_help_default_props_after_children
Conversation
imitate properly react createElement calls order
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11291/ |
JLHwung
approved these changes
Aug 8, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jsx helper used in the babel-plugin-transform-react-inline-elements was actually not perfectly imitating the react behavior as seen here.
In particular, the order is resolve the children, then resolve the defaultProps. Not the opposite.
I had a bug with
defaultProps: { children: null }that was appearing only when in production (when using the babel-plugin-transform-react-inline-elements), my children were undefined (which is an invariant error) even though I had defaultProps. This is the reason.