Skip to content

Replace es.string.reverse with es.array.reverse#10284

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
epicfaace:reverse
Aug 1, 2019
Merged

Replace es.string.reverse with es.array.reverse#10284
nicolo-ribaudo merged 1 commit intobabel:masterfrom
epicfaace:reverse

Conversation

@epicfaace
Copy link
Copy Markdown
Contributor

Q                       A
Fixed Issues? Fixes #10076
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? N
License MIT

Replace es.string.reverse with es.array.reverse for corejs@3 definitions. You can see that only es.array.reverse exists in corejs@3.

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11267/

@JLHwung JLHwung added pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 31, 2019
@nicolo-ribaudo
Copy link
Copy Markdown
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 6672763 into babel:master Aug 1, 2019
@epicfaace epicfaace deleted the reverse branch August 1, 2019 15:24
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no es.string.reverse in babel-preset-env/corejs3/built-in-definitions

4 participants