Resolved issue with dev tools by microtechno9000 · Pull Request #966 · automatic-ripping-machine/automatic-ripping-machine

microtechno9000 · 2023-10-26T12:05:30Z

Description

Resolved issue with the ARM DevTools (details below)
Resolved some typos and other minor QA fixes

Fixes
as above

Type of change

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update
update required from Ntfy and Bash for notifications #930 for the notifications addition

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Docker

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have tested that my fix is effective or that my feature works

Changelog:

Per review files

Logs

Attach logs from successful test runs here

resolved error

$ ./armdevtools.py -h
Traceback (most recent call last):
  File "/home/mtech/Projects/automatic-ripping-machine/devtools/./armdevtools.py", line 19, in <module>
    import armnotify
  File "/home/mtech/Projects/automatic-ripping-machine/devtools/armnotify.py", line 11, in <module>
    from arm.models.models import Job
ModuleNotFoundError: No module named 'arm'

Note, due to now linking/referencing arm, the devtools start flask, this is not ideal, but without extracting code and duplicating ripper.utils functionality I can't see a clean way to avoid this.

$ ./armdevtools.py -h
[2023-10-26 22:17:32,563] DEBUG ARM: __init__.<module> Debugging pin: 12345
[2023-10-26 22:17:32,931] DEBUG ARM: utils.arm_alembic_get Alembic Head is: 2e0dc31fcb2e
[2023-10-26 22:17:32,979] DEBUG ARM: utils.arm_db_get Database Head is: 2e0dc31fcb2e
[2023-10-26 22:17:32,979] DEBUG ARM: utils.arm_db_check Database is current. Head: 2e0dc31fcb2eDB: 2e0dc31fcb2e
[2023-10-26 22:17:32,983] DEBUG ARM: utils.arm_db_cfg UISettings: (_sa_instance_state=<sqlalchemy.orm.state.InstanceState object at 0x7f4ca8812980>) (use_icons=True) (bootstrap_skin=spacelab) (index_refresh=10) (database_limit=200) (save_remote_images=True) (id=1) (language=en) (notify_refresh=6500) 
[2023-10-26 22:17:32,989] DEBUG ARM: utils.arm_alembic_get Alembic Head is: 2e0dc31fcb2e
[2023-10-26 22:17:32,990] DEBUG ARM: utils.arm_db_get Database Head is: 2e0dc31fcb2e
[2023-10-26 22:17:32,990] DEBUG ARM: utils.arm_db_check Database is current. Head: 2e0dc31fcb2eDB: 2e0dc31fcb2e
[2023-10-26 22:17:32,991] DEBUG ARM: utils.arm_db_cfg UISettings: (_sa_instance_state=<sqlalchemy.orm.state.InstanceState object at 0x7f4ca8812980>) (use_icons=True) (bootstrap_skin=spacelab) (index_refresh=10) (database_limit=200) (save_remote_images=True) (id=1) (language=en) (notify_refresh=6500) 
usage: armdevtools.py [-h] [-b B] [-dr DR] [-db_rem] [-qa] [-pr] [-n] [-v]

Automatic Ripping Machine Development Tool Scripts. Note: scripts assume running on a bare
metal server when running, unless running the specific docker rebuild scripts.

options:
  -h, --help  show this help message and exit
  -b B        Name of the branch to move to, example -b v2_devel
  -dr DR      Docker rebuild post ARM code update. Requires docker run script path to run.
  -db_rem     Database tool - remove current arm.db file
  -qa         QA Checks - run Flake8 against ARM
  -pr         Actions to run prior to committing a PR against ARM on github
  -n          Notification tool - show a test notification
  -v          ARM Dev Tools Version

sonarqubecloud · 2023-10-26T12:17:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

resolved issue with devtools and fixed some minor formatting issues

6ac42ea

microtechno9000 changed the title ~~resolved issue with devtools and fixed some minor formatting issues~~ Resolved issue with dev tools Oct 26, 2023

E402 fix

7ddfcea

microtechno9000 marked this pull request as ready for review October 26, 2023 12:17

shitwolfymakes approved these changes Oct 27, 2023

View reviewed changes

shitwolfymakes merged commit a11db9c into automatic-ripping-machine:main Oct 27, 2023

microtechno9000 deleted the devtools_fix branch October 28, 2023 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolved issue with dev tools#966

Resolved issue with dev tools#966
shitwolfymakes merged 2 commits intoautomatic-ripping-machine:mainfrom
microtechno9000:devtools_fix

microtechno9000 commented Oct 26, 2023

Uh oh!

sonarqubecloud bot commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

microtechno9000 commented Oct 26, 2023

Description

Type of change

How Has This Been Tested?

Checklist:

Changelog:

Logs

Uh oh!

sonarqubecloud bot commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants