Updating Node version in Engines spec in package.json#528
Updating Node version in Engines spec in package.json#528ziluvatar merged 2 commits intoauth0:masterfrom
Conversation
Updated Node version from 0.12 to 1.4 in package.json engines
|
I was going to check if the package is still compatible with that old version, however, I think it is better to state in the package json the versions we actually care about (we have CI set on them), so that would be |
|
where do you want me to update that in package json? |
|
I think @ziluvatar was saying to set the node version to |
|
Ok will do that now |
Updated Node version from 0.12 to 4 in package.json Engines Spec Fixes Issue auth0#509
MitMaro
left a comment
There was a problem hiding this comment.
From the npm docs:
Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.
So even if this does show a warning for some users, it shouldn't be too big of an issue.
|
Thanks MitMaro, I was wondering what kind of release this should be, I think it will be in the next patch one, because, in the project we were really treating node 4 as the minimum node version, this is a fix just for the package.json (we could have broken compatibility with older than v4 at any moment, since it would have been fine to us). |
Updated Node version from 0.12 to 1.4 in package.json Engines Spec
Fixes Issue #509