Make code-coverage mandatory when running tests#495
Merged
ziluvatar merged 3 commits intoauth0:masterfrom Jun 25, 2018
Merged
Conversation
ziluvatar
reviewed
Jun 25, 2018
Contributor
ziluvatar
left a comment
There was a problem hiding this comment.
Can you resolve conflicts?
I'm not sure what values should be the right ones. Since this is passing we can leave it as is and tweak them if needed.
| "reporter": [ | ||
| "json", | ||
| "lcov", | ||
| "text-summary" |
Contributor
There was a problem hiding this comment.
does this mean no HTML reporter?
Contributor
Author
There was a problem hiding this comment.
Preferably it should be 100% coverage, but as we are missing some tests on exception handling and @MitMaro is in the process of refactoring the tests, i was being liberate ;-)
Lcov includes a html reporter :-)
ziluvatar
approved these changes
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #486, made the coverage-check mandatory when running test.