Support TypeDirective for ArgumentDefinition, Enum, EnumValue, InputFieldDefinition, InputObject, Interface#1509
Merged
sunli829 merged 1 commit intoasync-graphql:masterfrom May 1, 2024
Conversation
Contributor
|
Well, that's definitely a worthy PR, thank you so much! @sunli829, could you check it, please? Seems like the most of the code has the same foundation as |
Collaborator
|
thanks 🙂 |
Contributor
|
Sorry, my bad. It has appeared due to the consequential avalanche merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Up until now,
TypeDirectivewas only supported forFIELD_DEFINITIONandOBJECT.However, this was insufficient, so I have made adjustments to allow the implementation of
TypeDirectiveforArgumentDefinition,Enum,EnumValue,InputFieldDefinition,InputObject, andInterfaceas well.I have attached the complete sample code and the outputted GraphQL schema below for your review.
I would appreciate it if you could take a look.
Sample Code
Rust
Generated GraphQL