RUF022, RUF023: never add two trailing commas to the end of a sequence#9698
Merged
AlexWaygood merged 6 commits intoastral-sh:mainfrom Jan 30, 2024
Merged
RUF022, RUF023: never add two trailing commas to the end of a sequence#9698AlexWaygood merged 6 commits intoastral-sh:mainfrom
AlexWaygood merged 6 commits intoastral-sh:mainfrom
Conversation
Contributor
|
AlexWaygood
commented
Jan 30, 2024
Comment on lines
+1009
to
+1022
| ℹ Safe fix | ||
| 241 241 | ] | ||
| 242 242 | | ||
| 243 243 | __all__ = ( | ||
| 244 |- "foo" | ||
| 245 244 | # strange comment 1 | ||
| 246 |- , | ||
| 247 245 | # comment about bar | ||
| 248 |- "bar" | ||
| 246 |+ "bar", | ||
| 247 |+ "foo" | ||
| 249 248 | # strange comment 2 | ||
| 250 249 | , | ||
| 251 250 | ) |
Member
Author
There was a problem hiding this comment.
It's hard to say where a comment like # strange comment 1 should go really, if it lies between the string item and the associated comma. Possibly it should move with "foo", even though it's directly above "bar". But this is a very unlikely edge case, and the important thing is that the comment isn't deleted, in my opinion.
charliermarsh
approved these changes
Jan 30, 2024
MichaReiser
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issues highlighted in #8402 (comment) and #8402 (comment)