Skip to content

[pylint] - implement redeclared-assigned-name (W0128)#9268

Merged
zanieb merged 5 commits intoastral-sh:mainfrom
diceroll123:add-W0128
Mar 15, 2024
Merged

[pylint] - implement redeclared-assigned-name (W0128)#9268
zanieb merged 5 commits intoastral-sh:mainfrom
diceroll123:add-W0128

Conversation

@diceroll123
Copy link
Contributor

@diceroll123 diceroll123 commented Dec 24, 2023

Summary

Implements W0128/redeclared-assigned-name

See: #970

Test Plan

cargo test

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

apache/airflow (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ tests/providers/common/sql/operators/test_sql.py:237:20: PLW0128 Redeclared variable `operator` in assignment

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLW0128 1 1 0 0 0

@diceroll123 diceroll123 changed the title [pylint] - implement W0128/redeclared-assigned-name [pylint] - implement W0128/redeclared-assigned-name Dec 25, 2023
@diceroll123 diceroll123 changed the title [pylint] - implement W0128/redeclared-assigned-name [pylint] - implement W0128/redeclared-assigned-name Jan 20, 2024
@diceroll123 diceroll123 changed the title [pylint] - implement W0128/redeclared-assigned-name [pylint] - implement redeclared-assigned-name (W0128) Jan 21, 2024
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just needs that small docs change

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2024

CodSpeed Performance Report

Merging #9268 will not alter performance

Comparing diceroll123:add-W0128 (ab12b93) with main (9675e18)

Summary

✅ 30 untouched benchmarks

@diceroll123
Copy link
Contributor Author

Updated accordingly, and added support for the dummy variable setting instead of just using _. 😄

@diceroll123 diceroll123 requested a review from zanieb March 15, 2024 04:32
@zanieb zanieb merged commit 740c08b into astral-sh:main Mar 15, 2024
@zanieb zanieb added rule Implementing or modifying a lint rule preview Related to preview mode features labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants