Allow selective caching for --fix and --diff#8316
Merged
charliermarsh merged 1 commit intomainfrom Oct 29, 2023
Merged
Conversation
0db023a to
fbaa8cd
Compare
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no linter changes. |
zanieb
approved these changes
Oct 28, 2023
Member
zanieb
left a comment
There was a problem hiding this comment.
Nice. Should we retain a note about why we don't always cache?
fbaa8cd to
65db980
Compare
Contributor
|
I can confirm this solves #8311, second run of |
Member
Author
|
Nice, thanks for testing on |
Member
Author
|
I'd expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a file has no diagnostics, then we can read and write that information from and to the cache, even if the fix mode is
--fixor--diff. (Typically, we can't read or write such results from or to the cache, because--fixand--diffhave side effects that take place during diagnostic analysis (writing to disk or outputting the diff).) This greatly improves performance when running--fixon a codebase in the common case (few diagnostics).Closes #8311.
Closes #8315.