[ruff] Do not remove parens for tuples with starred expressions in Python <=3.10 RUF031#12784
Merged
MichaReiser merged 3 commits intoastral-sh:mainfrom Aug 9, 2024
Merged
Conversation
Contributor
|
Collaborator
Author
|
As far as I understand, it's not possible to have something like |
Collaborator
Author
|
Converting to draft until we sort out which versions this should apply to (#12776 (comment)) update: all sorted! #12776 (comment) |
RUF031RUF031
MichaReiser
approved these changes
Aug 9, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
This is great. Thank you so much for swiftly addressing the incoming issues!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Python versions <=3.10, removing the parentheses in expressions like
d[(*foo,bar)]leads to a syntax error. This PR skips the check forincorrectly-parenthesized-tuple-in-subscript (RUF031)in the situation where:lint.target-version <= 3.10lint.ruff.parenthesize-tuple-in-subscript = false(which is the default setting)Closes #12776