Skip to content

[refurb] - fix unused autofix for implicit-cwd (FURB177)#12708

Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom
diceroll123:fix-unused-autofix
Aug 6, 2024
Merged

[refurb] - fix unused autofix for implicit-cwd (FURB177)#12708
MichaReiser merged 1 commit intoastral-sh:mainfrom
diceroll123:fix-unused-autofix

Conversation

@diceroll123
Copy link
Copy Markdown
Contributor

Summary

The autofix for this already existed, it just was not pushed to the checker.

Test Plan

cargo test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Copy Markdown
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

I wondered if there was a reason for not pushing the fix, but nope. Has been like this since the rule was added.

Thanks for PRing the fix to add the right diagnostic ;)

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Aug 6, 2024
@MichaReiser MichaReiser merged commit 39dd732 into astral-sh:main Aug 6, 2024
dylwil3 pushed a commit to dylwil3/ruff that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants