Add newlines before comments in E305#12606
Merged
charliermarsh merged 1 commit intomainfrom Aug 1, 2024
Merged
Conversation
Contributor
|
|
Are comments always tied to the next code line independent of indentation? Or does the indentation of a comment control where the empty lines are inserted? |
Member
Author
|
Should be the latter (controlled by indentation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There's still a problem here. Given:
We only add one newline before
a = 1on the first pass, becausemax_precedling_blank_linesis 1... We then add the second newline on the second pass, so it ends up in the right state, but the logic is clearly wonky.Closes #11508.