Skip to content

Don't attach comments with mismatched indents#12604

Merged
charliermarsh merged 1 commit intomainfrom
charlie/start
Aug 1, 2024
Merged

Don't attach comments with mismatched indents#12604
charliermarsh merged 1 commit intomainfrom
charlie/start

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

Given:

def test_update():
    pass
    # comment
def test_clientmodel():
    pass

We don't want # comment to be attached to def test_clientmodel().

Closes #12589.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 1, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) August 1, 2024 01:57
@charliermarsh charliermarsh disabled auto-merge August 1, 2024 01:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 7e6b190 into main Aug 1, 2024
@charliermarsh charliermarsh deleted the charlie/start branch August 1, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixing file with rules E302, E303 cause infinite loop

1 participant