add conventional xml.etree.ElementTree import alias#12455
Merged
MichaReiser merged 3 commits intoastral-sh:ruff-0.6from Aug 12, 2024
Merged
add conventional xml.etree.ElementTree import alias#12455MichaReiser merged 3 commits intoastral-sh:ruff-0.6from
MichaReiser merged 3 commits intoastral-sh:ruff-0.6from
Conversation
Member
|
You need to add this to |
charliermarsh
approved these changes
Jul 25, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks. I think this is reasonable to include but it'll have to wait until the next minor version.
Merged
AlexWaygood
pushed a commit
that referenced
this pull request
Aug 14, 2024
MichaReiser
pushed a commit
that referenced
this pull request
Aug 14, 2024
MichaReiser
pushed a commit
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a conventional alias for ElementTree. I looked for other conventional aliases in standard library in order to generalize the point, but found none.
There is still an issue with this. It conflicts with
N817 CamelCase 'ElementTree' imported as acronym 'ET'. I have to ignore locally:import xml.etree.ElementTree as ET # noqa: N817too bad
Test Plan
only test as a
lint.flake8-import-conventions.extend-aliasesconfiguration option