[pydoclint] Fix DOC501 panic #12428#12435
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Jul 21, 2024
Merged
Conversation
| @@ -210,7 +210,7 @@ fn parse_entries_numpy(content: &str) -> Vec<QualifiedName> { | |||
| for potential in split { | |||
| if let Some(first_char) = potential.chars().nth(indentation) { | |||
Member
There was a problem hiding this comment.
Could we use strip_prefix here with the indentation instead of using chars?
Contributor
Author
There was a problem hiding this comment.
Ok I reimplemented using strip_prefix but I still needed to call chars to check if the first char is_whitepace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix panic reported in #12428. Where a string would sometimes get split within a character boundary. This bypasses the need to split the string.
This does not guarantee the correct formatting of the docstring, but neither did the previous implementation.
Resolves #12428
Test Plan
Test case added to fixture