[pyupgrade] Implement unnecessary-default-type-args (UP043)#12371
Merged
charliermarsh merged 5 commits intoastral-sh:mainfrom Jul 17, 2024
Merged
Conversation
pyupgrade] Implement unnecessary default type args (UP043)pyupgrade] Implement unnecessary-default-type-args (UP043)
Member
|
Nice, thank you! Will review. |
charliermarsh
approved these changes
Jul 17, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
This is great, thank you. I just made some minor tweaks to formatting and docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new rule and implement for
unnecessary default type argumentsunder theUPcategory (UP043).I think that as Python 3.13 develops, there might be more default type arguments added besides
GeneratorandAsyncGenerator. So, I made this more flexible to accommodate future changes.related issue: #12286
Test Plan
snapshot included..!