Ignore self and cls when counting arguments#12367
Merged
charliermarsh merged 1 commit intomainfrom Jul 17, 2024
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLR0913 | 3858 | 1650 | 2208 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1650 -2208 violations, +0 -0 fixes in 4 projects; 50 projects unchanged)
apache/airflow (+1544 -2031 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/api/client/api_client.py:34:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/api/client/json_client.py:60:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/api/client/local_client.py:32:9: PLR0913 Too many arguments in function definition (6 > 5) + airflow/callbacks/callback_requests.py:114:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/callbacks/callback_requests.py:114:9: PLR0913 Too many arguments in function definition (7 > 5) - airflow/callbacks/callback_requests.py:76:9: PLR0913 Too many arguments in function definition (6 > 5) + airflow/cli/cli_config.py:79:9: PLR0913 Too many arguments in function definition (10 > 5) - airflow/cli/cli_config.py:79:9: PLR0913 Too many arguments in function definition (11 > 5) + airflow/cli/commands/webserver_command.py:85:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/cli/commands/webserver_command.py:85:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:1062:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/configuration.py:1062:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:1083:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/configuration.py:1083:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:1104:9: PLR0913 Too many arguments in function definition (7 > 5) - airflow/configuration.py:1104:9: PLR0913 Too many arguments in function definition (8 > 5) + airflow/configuration.py:1126:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/configuration.py:1126:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:1393:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/configuration.py:1393:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:553:9: PLR0913 Too many arguments in function definition (10 > 5) - airflow/configuration.py:553:9: PLR0913 Too many arguments in function definition (11 > 5) + airflow/configuration.py:612:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/configuration.py:612:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/configuration.py:639:9: PLR0913 Too many arguments in function definition (11 > 5) - airflow/configuration.py:639:9: PLR0913 Too many arguments in function definition (12 > 5) + airflow/dag_processing/manager.py:122:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/dag_processing/manager.py:122:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/dag_processing/manager.py:363:9: PLR0913 Too many arguments in function definition (7 > 5) - airflow/dag_processing/manager.py:363:9: PLR0913 Too many arguments in function definition (8 > 5) - airflow/dag_processing/processor.py:84:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/datasets/manager.py:71:9: PLR0913 Too many arguments in function definition (6 > 5) + airflow/decorators/__init__.pyi:171:9: PLR0913 Too many arguments in function definition (6 > 5) - airflow/decorators/__init__.pyi:171:9: PLR0913 Too many arguments in function definition (7 > 5) + airflow/decorators/__init__.pyi:353:9: PLR0913 Too many arguments in function definition (46 > 5) - airflow/decorators/__init__.pyi:353:9: PLR0913 Too many arguments in function definition (47 > 5) + airflow/decorators/__init__.pyi:501:9: PLR0913 Too many arguments in function definition (59 > 5) - airflow/decorators/__init__.pyi:501:9: PLR0913 Too many arguments in function definition (60 > 5) - airflow/decorators/base.py:191:9: PLR0913 Too many arguments in function definition (6 > 5) + airflow/executors/base_executor.py:156:9: PLR0913 Too many arguments in function definition (10 > 5) - airflow/executors/base_executor.py:156:9: PLR0913 Too many arguments in function definition (11 > 5) + airflow/executors/debug_executor.py:96:9: PLR0913 Too many arguments in function definition (10 > 5) - airflow/executors/debug_executor.py:96:9: PLR0913 Too many arguments in function definition (11 > 5) + airflow/jobs/backfill_job_runner.py:115:9: PLR0913 Too many arguments in function definition (17 > 5) - airflow/jobs/backfill_job_runner.py:115:9: PLR0913 Too many arguments in function definition (18 > 5) - airflow/jobs/backfill_job_runner.py:846:9: PLR0913 Too many arguments in function definition (6 > 5) ... 3529 additional changes omitted for project
apache/superset (+38 -61 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- superset/async_events/async_query_manager.py:186:9: PLR0913 Too many arguments in function definition (6 > 5) - superset/commands/database/uploaders/base.py:133:9: PLR0913 Too many arguments in function definition (6 > 5) - superset/commands/sql_lab/execute.py:70:9: PLR0913 Too many arguments in function definition (10 > 5) + superset/commands/sql_lab/execute.py:70:9: PLR0913 Too many arguments in function definition (9 > 5) - superset/common/query_context.py:64:9: PLR0913 Too many arguments in function definition (10 > 5) + superset/common/query_context.py:64:9: PLR0913 Too many arguments in function definition (9 > 5) + superset/common/query_context_factory.py:47:9: PLR0913 Too many arguments in function definition (7 > 5) - superset/common/query_context_factory.py:47:9: PLR0913 Too many arguments in function definition (8 > 5) - superset/common/query_context_processor.py:344:9: PLR0913 Too many arguments in function definition (6 > 5) + superset/common/query_object.py:110:9: PLR0913 Too many arguments in function definition (21 > 5) ... 89 additional changes omitted for project
bokeh/bokeh (+20 -38 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- src/bokeh/client/connection.py:85:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/client/session.py:277:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/constraints.py:56:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/container.py:324:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/descriptors.py:562:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/descriptors.py:660:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/numeric.py:159:9: PLR0913 Too many arguments in function definition (6 > 5) - src/bokeh/core/property/wrappers.py:438:9: PLR0913 Too many arguments in function definition (6 > 5) + src/bokeh/document/callbacks.py:223:9: PLR0913 Too many arguments in function definition (7 > 5) - src/bokeh/document/callbacks.py:223:9: PLR0913 Too many arguments in function definition (8 > 5) ... 48 additional changes omitted for project
zulip/zulip (+48 -78 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- analytics/lib/counts.py:91:9: PLR0913 Too many arguments in function definition (6 > 5) + analytics/management/commands/populate_analytics_db.py:47:9: PLR0913 Too many arguments in function definition (8 > 5) - analytics/management/commands/populate_analytics_db.py:47:9: PLR0913 Too many arguments in function definition (9 > 5) - analytics/tests/test_counts.py:207:9: PLR0913 Too many arguments in function definition (6 > 5) + analytics/tests/test_counts.py:226:9: PLR0913 Too many arguments in function definition (6 > 5) - analytics/tests/test_counts.py:226:9: PLR0913 Too many arguments in function definition (7 > 5) + corporate/lib/stripe.py:1614:9: PLR0913 Too many arguments in function definition (8 > 5) - corporate/lib/stripe.py:1614:9: PLR0913 Too many arguments in function definition (9 > 5) - corporate/lib/stripe.py:1711:9: PLR0913 Too many arguments in function definition (10 > 5) + corporate/lib/stripe.py:1711:9: PLR0913 Too many arguments in function definition (9 > 5) ... 116 additional changes omitted for project
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLR0913 | 3858 | 1650 | 2208 | 0 | 0 |
Member
|
Should this change go under preview? I think most changes in the ecosystem should cancel each other out (just a decrease in the count) but it seems like there are lot of violations in addition to that. |
Member
Author
|
No (IMO), because it only reduces the number of violations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12320.