This repository was archived by the owner on May 26, 2023. It is now read-only.
Merged
Conversation
|
@spencersteers: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Author
|
Found an easy fix for whats mentioned above by calling |
abernix
approved these changes
Aug 28, 2019
Member
abernix
left a comment
There was a problem hiding this comment.
Let's punt the other fixes to another PR, mainly so that we have separate published versions which fix different problems in case someone runs into concerns with one fix or the other. 😄
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-server#2529.
Changes proposed in this pull request:
changeWidthDocsso that the tabs can resize@abernix
Side not I also noticed an issue that occurs when:
This is also occurring in prisma. Should I try to take care of this as well or want to just get this fix in?