apollo-engine-reporting: fix maxAttempts parameter, log 5xx body#3218
Merged
trevor-scheer merged 1 commit intomasterfrom Aug 27, 2019
Merged
apollo-engine-reporting: fix maxAttempts parameter, log 5xx body#3218trevor-scheer merged 1 commit intomasterfrom
trevor-scheer merged 1 commit intomasterfrom
Conversation
abernix
approved these changes
Aug 27, 2019
- The behavior of maxAttempts previously failed to match its documentation or the literal reading of its name. Previously, setting maxAttempts=1 would actually result in one retry after the initial attempt. This change fixes the behavior to match the docs and the name. - We intend the bodies of Engine report endpoint errors to be useful in error logs, even 5xx errors. This change returns to including them in the reported error. PR #1274 (merged before the initial release of apollo-engine-reporting) regressed both of these issues.
781108d to
455e57f
Compare
trevor-scheer
approved these changes
Aug 27, 2019
Member
Author
|
Just a note @abernix that this got more stuff in it after you approved. |
Member
|
I appreciate the post-factum ping, @glasser! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of maxAttempts previously failed to match its documentation or
the literal reading of its name. Previously, setting maxAttempts=1 would
actually result in one retry after the initial attempt. This change fixes
the behavior to match the docs and the name.
We intend the bodies of Engine report endpoint errors to be useful in error
logs, even 5xx errors. This change returns to including them in the reported
error.
PR #1274 (merged before the initial release of apollo-engine-reporting)
regressed both of these issues.