Skip to content

Fix causing multiple operations to sometimes be incorrectly executed#3084

Merged
jbaxleyiii merged 2 commits intomasterfrom
jackson/fix-operationName-bug
Jul 25, 2019
Merged

Fix causing multiple operations to sometimes be incorrectly executed#3084
jbaxleyiii merged 2 commits intomasterfrom
jackson/fix-operationName-bug

Conversation

@JacksonKearl
Copy link
Copy Markdown

@JacksonKearl JacksonKearl commented Jul 25, 2019

We were caching the query plan based on only the query hash, which gave problems when operationName was different for the same query.

@JacksonKearl JacksonKearl changed the title Fix causing operation name to sometimes be incorrectly done Fix causing multiple operations to sometimes be incorrectly executed Jul 25, 2019
@jbaxleyiii jbaxleyiii merged commit 7660727 into master Jul 25, 2019
abernix added a commit that referenced this pull request Jul 25, 2019
@abernix abernix deleted the jackson/fix-operationName-bug branch February 25, 2020 21:03
abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…l/jackson/fix-operationName-bug

Fix causing multiple operations to sometimes be incorrectly executed
Apollo-Orig-Commit-AS: apollographql/apollo-server@7660727
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants