Skip to content

fix Cannot read property 'some' of undefined in apollo-server-core/di…#2924

Merged
abernix merged 9 commits intoapollographql:masterfrom
mrsunboss:fix/isDirectiveDefined
Jun 26, 2019
Merged

fix Cannot read property 'some' of undefined in apollo-server-core/di…#2924
abernix merged 9 commits intoapollographql:masterfrom
mrsunboss:fix/isDirectiveDefined

Conversation

@mrsunboss
Copy link
Copy Markdown
Contributor

@mrsunboss mrsunboss commented Jun 26, 2019

fix Cannot read property 'some' of undefined in apollo-server-core/dist/utils/isDirectiveDefined.js

Fixes #2921

@apollo-cla
Copy link
Copy Markdown

@mrsunboss: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix abernix added this to the Release 2.6.7 milestone Jun 26, 2019
abernix added 4 commits June 26, 2019 14:25
Specifically, make sure to test all possibilities which might come in here.
…eality.

While no TypeScript user would have ever been able to use it as such, Apollo
Server has for a long time (as a side-effect of its past reliance on
`graphql-tools`) accepted string types (and arrays of string types) for
`typeDefs`.

This hasn't been reflected in the TypeScript types, and has thus made it
possible to sandbag non-TypeScript users (which let's remind ourselves, is
still the majority) who were strings, when new code — like that in apollographql#2762 —
didn't defend against what TypeScript indicated would be fine.

Even if we don't necessarily support string types as a common pattern
anymore, they still work, and we need to make sure we're coding for what we
expect to work until the time comes to make a breaking change.
@abernix abernix merged commit 5d4b790 into apollographql:master Jun 26, 2019
abernix added a commit that referenced this pull request Jun 26, 2019
@abernix
Copy link
Copy Markdown
Member

abernix commented Jun 26, 2019

Thank you very much for submitting this! I've added some regression tests and fixed the likely reason this was introduced in the first place in some follow-up commits, if you're interested.

@mrsunboss
Copy link
Copy Markdown
Contributor Author

Thank you very much.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when reading typedef from file in V2.6.6

3 participants