fix: strip @external fields in interface extensions#2848
Merged
JakeDawkins merged 3 commits intoapollographql:masterfrom Jun 17, 2019
Merged
fix: strip @external fields in interface extensions#2848JakeDawkins merged 3 commits intoapollographql:masterfrom
JakeDawkins merged 3 commits intoapollographql:masterfrom
Conversation
|
@lennyburdette: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
JakeDawkins
suggested changes
Jun 14, 2019
Contributor
JakeDawkins
left a comment
There was a problem hiding this comment.
Thanks so much! Just one slight change, and should be good to go 👍
Before this change, including an external field in an interface extension would fail composition in the gateway with an error: ``` Field "Product.id" already exists in the schema. It cannot also be defined in this type extension. ```
ffabb64 to
b61239e
Compare
JakeDawkins
approved these changes
Jun 15, 2019
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ollo-server#2848) Before this change, including an external field in an interface extension would fail composition in the gateway with an error: ``` Field "Product.id" already exists in the schema. It cannot also be defined in this type extension. ``` Apollo-Orig-Commit-AS: apollographql/apollo-server@c883224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, including an external field in an interface
extension would fail composition in the gateway with an error: