[Federation] Add queryHash to GraphQLExecutor#2822
Merged
jbaxleyiii merged 1 commit intoapollographql:masterfrom Jun 12, 2019
Merged
[Federation] Add queryHash to GraphQLExecutor#2822jbaxleyiii merged 1 commit intoapollographql:masterfrom
jbaxleyiii merged 1 commit intoapollographql:masterfrom
Conversation
Currently due to core-package not allowing queryHash
You have the following error when building an ApolloGateway with Typescript.
Property 'executor' in type 'ApolloGateway' is not assignable to the same property in base type 'GraphQLService'.
Type '<TContext>(requestContext: WithRequired<GraphQLRequestContext<TContext>, "document" | "operation" | "queryHash">) => Promise<GraphQLExecutionResult>' is not assignable to type 'GraphQLExecutor<Record<string, any>>'.
Types of parameters 'requestContext' and 'requestContext' are incompatible.
Type 'WithRequired<GraphQLRequestContext<Record<string, any>>, "document" | "operationName" | "operation">' is not assignable to type 'WithRequired<GraphQLRequestContext<Record<string, any>>, "document" | "operation" | "queryHash">'.
Type 'WithRequired<GraphQLRequestContext<Record<string, any>>, "document" | "operationName" | "operation">' is not assignable to type 'Required<Pick<GraphQLRequestContext<Record<string, any>>, "document" | "operation" | "queryHash">>'.
Property 'queryHash' is optional in type 'GraphQLRequestContext<Record<string, any>> & Required<Pick<GraphQLRequestContext<Record<string, any>>, "document" | "operationName" | "operation">>' but required in type 'Required<Pick<GraphQLRequestContext<Record<string, any>>, "document" | "operation" | "queryHash">>'.ts(2416)
By allowing queryHash this should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently due to core-package not allowing queryHash
You have the following error when building an ApolloGateway with Typescript.
By allowing queryHash this should be fixed.