Remove Object.fromEntries usage (node 12 only)#2787
Merged
trevor-scheer merged 3 commits intomasterfrom Jun 6, 2019
Merged
Conversation
jbaxleyiii
suggested changes
Jun 6, 2019
Contributor
jbaxleyiii
left a comment
There was a problem hiding this comment.
@trevor-scheer can you add a comment about why we don't use fromEntries here for future collaborators?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an invalid use of
Object.fromEntries. This function is currently only supported by Node 12. See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntriesI created a small, hand validation of this change for my own confirmation here:
https://runkit.com/trevor-scheer/5cf933b15f7a26001ba9a9c6
Closes #2775