Skip to content

[apollo-server-plugin-base] fix GraphQLRequestListener type definitions#2368

Merged
abernix merged 4 commits intoapollographql:masterfrom
doomsower:fix-plugin-ts
Jun 30, 2019
Merged

[apollo-server-plugin-base] fix GraphQLRequestListener type definitions#2368
abernix merged 4 commits intoapollographql:masterfrom
doomsower:fix-plugin-ts

Conversation

@doomsower
Copy link
Copy Markdown
Contributor

@doomsower doomsower commented Feb 24, 2019 •
edited
Loading

This makes typescript compiler happy when listers return void:

export class SomeListener implements GraphQLRequestListener {
  parsingDidStart() {
    console.log('parsingDidStart');
  }
}

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

abernix
abernix approved these changes Jun 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit bf0cd6b into apollographql:master Jun 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abernix abernix abernix approved these changes

@martijnwalraven martijnwalraven Awaiting requested review from martijnwalraven

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doomsower @abernix