Remove willStart from apollo-server, already called via …-express.#2239
Merged
Remove willStart from apollo-server, already called via …-express.#2239
willStart from apollo-server, already called via …-express.#2239Conversation
…ess`. When the request pipeline was initially introduced, the integrations had yet to be updated to call the new life-cycle events. Now, the integrations have all caught up, but `apollo-server` is still calling `willStart`, despite the fact that its dependency which provides the actual server implementation — `apollo-server-express` – is _also_ calling it, resulting in double invocation of this event. I suspect some follow-up work should guard against this possibility, but for now this should remove the duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the request pipeline was initially introduced, the integrations had yet to be updated to call the new life-cycle events. Now, the integrations have all caught up, but
apollo-serveris still callingwillStart, despite the fact that its dependency which provides the actual server implementation —apollo-server-express– is also calling it, resulting in double invocation of this event.I suspect some follow-up work should guard against this possibility, but for
now this should remove the duplication.