Skip to content

Fix cloud functions tests#1611

Closed
reaktivo wants to merge 6 commits intoapollographql:masterfrom
reaktivo:fix-cloud-functions-tests
Closed

Fix cloud functions tests#1611
reaktivo wants to merge 6 commits intoapollographql:masterfrom
reaktivo:fix-cloud-functions-tests

Conversation

@reaktivo
Copy link
Copy Markdown
Contributor

@reaktivo reaktivo commented Sep 4, 2018

A few weeks ago the Google Cloud Functions implementation that I worked on was merged with tests that were never run. This was reported by @martijnwalraven here.

I've created this issue which moves tests to their correct location and fixes some edge cases that were caught by the integration test suite when actually run.

@martijnwalraven I've included your changes here, I hope you don't mind.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant