Skip to content

Honor @nonreactive with useFragment and cache.watchFragment#11844

Merged
jerelmiller merged 9 commits intomainfrom
jerel/issue-11785-usefragment-nonreactive
May 14, 2024
Merged

Honor @nonreactive with useFragment and cache.watchFragment#11844
jerelmiller merged 9 commits intomainfrom
jerel/issue-11785-usefragment-nonreactive

Conversation

@jerelmiller
Copy link
Copy Markdown
Member

@jerelmiller jerelmiller commented May 13, 2024

Fixes #11785

Uses equalByQuery to ensure that when we compare fragment diffs, we respect the @nonreactive directive within cache.watchFragment and useFragment.

@jerelmiller jerelmiller requested review from alessbell and phryneas May 13, 2024 18:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: abdc874

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.65 KB (-0.01% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.42 KB (+0.71% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.99 KB (+0.69% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.2 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.06 KB (-0.03% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.36 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.52 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.59 KB (0%)
import { useMutation } from "dist/react/index.js" 3.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.74 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.33 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.27 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2024

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 11d577b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6642604d38a4b80008028d63
😎 Deploy Preview https://deploy-preview-11844--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2024

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit abdc874
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/664260fb9a36c600087ee45a
😎 Deploy Preview https://deploy-preview-11844--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

phryneas
phryneas approved these changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions Bot added the auto-cleanup 🤖 label May 14, 2024
@jerelmiller jerelmiller merged commit 86984f2 into main May 14, 2024
@jerelmiller jerelmiller deleted the jerel/issue-11785-usefragment-nonreactive branch May 14, 2024 15:06
@github-actions github-actions Bot mentioned this pull request May 14, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@shonore shonore mentioned this pull request Jun 5, 2024
Open
@denysmiand denysmiand mentioned this pull request Jun 5, 2024
Open
@arddluma arddluma mentioned this pull request Jun 5, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 5, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 5, 2024
Open
@iamsatyanchal iamsatyanchal mentioned this pull request Jun 5, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 5, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Jun 5, 2024
Open
@peterleiva peterleiva mentioned this pull request Jun 5, 2024
Open
@basilisSam basilisSam mentioned this pull request Jun 6, 2024
Open
@shonore shonore mentioned this pull request Jun 6, 2024
Open
@MartinWitt MartinWitt mentioned this pull request Jun 6, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
Open
@sandermendes sandermendes mentioned this pull request Jun 8, 2024
Closed
This was referenced Jun 9, 2024
Open
Open
Open
Open
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@phryneas phryneas phryneas approved these changes

@alessbell alessbell Awaiting requested review from alessbell

Assignees

No one assigned

Labels

auto-cleanup 🤖

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useFragment doesn't respect the @nonreactive directive

2 participants

@jerelmiller @phryneas