Skip to content

chore: bump github.com/goccy/go-json to v0.10.4#218

Merged
zeroshade merged 1 commit intoapache:mainfrom
toddtreece:main
Dec 12, 2024
Merged

chore: bump github.com/goccy/go-json to v0.10.4#218
zeroshade merged 1 commit intoapache:mainfrom
toddtreece:main

Conversation

@toddtreece
Copy link
Copy Markdown
Contributor

Rationale for this change

A follow up to #199 (comment)

i will continue trying to get the go-json PR merged, and if i do, i'll open another PR to update the dependency here.

What changes are included in this PR?

Bumps go-json dependency to include changes from goccy/go-json#490

Are these changes tested?

I am assuming CI tests should cover this.

Are there any user-facing changes?

No

@zeroshade
Copy link
Copy Markdown
Member

zeroshade commented Dec 11, 2024

Would it be possible to get goccy to do a release of go-json rather than us pointing to a specific commit? Looks like the last release was back in May, so it would make sense to have a new release

@toddtreece
Copy link
Copy Markdown
Contributor Author

toddtreece commented Dec 11, 2024

@zeroshade i will try via gophers slack, but it might also help if you could comment on the go-json PR and ask for a release since this is a direct dependency of arrow-go

edit: link to message in gophers slack asking for a release

@toddtreece
Copy link
Copy Markdown
Contributor Author

toddtreece commented Dec 12, 2024

@zeroshade v0.10.4 was released 🎉. i updated this PR, so it should be ready for another look.

once this merges, would it be possible to create a new release of arrow-go? thanks for the help!

@toddtreece toddtreece changed the title chore: bump github.com/goccy/go-json chore: bump github.com/goccy/go-json to v0.10.4 Dec 12, 2024
@zeroshade
Copy link
Copy Markdown
Member

Once this merges, I think I would want to get a couple other PRs on here merged first and then I would be happy to start the release process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants