feat(arrow/ipc): add functions to generate payloads#196
Merged
zeroshade merged 1 commit intoapache:mainfrom Nov 26, 2024
Merged
feat(arrow/ipc): add functions to generate payloads#196zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@kou i'm not familiar enough with |
Member
|
9786155 to
bd708b1
Compare
lidavidm
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Brought up in apache/arrow#39730 requesting separate functions to generate the IPC Payloads for record batches (we have one for schemas in the Flight package, but it makes sense to have one in ipc which is more efficient).
What changes are included in this PR?
Two functions are added,
GetRecordBatchPayloadandGetSchemaPayloadwhich return ipc payload objects.Are these changes tested?
Yes, a unit test is added.
Are there any user-facing changes?
No.