Skip to content

fix(arrow/cdata): handle export struct with no fields#175

Merged
zeroshade merged 2 commits intoapache:mainfrom
zeroshade:panic-zero-fields
Oct 28, 2024
Merged

fix(arrow/cdata): handle export struct with no fields#175
zeroshade merged 2 commits intoapache:mainfrom
zeroshade:panic-zero-fields

Conversation

@zeroshade
Copy link
Copy Markdown
Member

Fixes #172

Includes a test that reproduced the original reported issue

@zeroshade
Copy link
Copy Markdown
Member Author

CC @ukclivecox

@ukclivecox
Copy link
Copy Markdown

ukclivecox commented Oct 25, 2024

Thanks @zeroshade
Would the same not happen at line 430 for Union handling as well?

@zeroshade
Copy link
Copy Markdown
Member Author

@ukclivecox updated to account for union arrays too

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zeroshade zeroshade merged commit b7e68db into apache:main Oct 28, 2024
@zeroshade zeroshade deleted the panic-zero-fields branch October 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic on zero length array in exportArray

3 participants