Skip to content

fix: dropdown down icon size#41501

Merged
afc163 merged 1 commit intomasterfrom
fix/dropdown-icon
Mar 28, 2023
Merged

fix: dropdown down icon size#41501
afc163 merged 1 commit intomasterfrom
fix/dropdown-icon

Conversation

@MadCcc
Copy link
Copy Markdown
Member

@MadCcc MadCcc commented Mar 28, 2023 •
edited by afc163
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image
大了一号，4.x 中处理过，5.x 丢了

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown.Button down icon wrong size.
🇨🇳 Chinese 修复 Dropdown.Button down 图标尺寸问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 28, 2023 •
edited
Loading

github-actions[bot]
github-actions Bot reviewed Mar 28, 2023
View reviewed changes
Comment thread components/dropdown/style/index.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 28, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.88 KB (-74 B 🔽)
./dist/antd-with-locales.min.js 431.82 KB (-75 B 🔽)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0c55526) 100.00% compared to head (ee864a0) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #41501   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       609    -1     
  Lines        10471     10468    -3     
  Branches      2861      2861           
=========================================
- Hits         10471     10468    -3
Impacted Files Coverage Δ
components/dropdown/style/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 3ef08ed into master Mar 28, 2023
@afc163 afc163 deleted the fix/dropdown-icon branch March 28, 2023 05:21
@xrkffgg xrkffgg mentioned this pull request Mar 28, 2023
Merged
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@MadCcc @RedJue
fix: dropdown down icon size (ant-design#41501)
b99d73f
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@MadCcc @RedJue
fix: dropdown down icon size (ant-design#41501)
526e997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@li-jia-nan li-jia-nan li-jia-nan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MadCcc @li-jia-nan @afc163