fix(menu): Render the correct theme when using 'getPopupContainer'#41465
Merged
afc163 merged 1 commit intoant-design:masterfrom Mar 27, 2023
Merged
fix(menu): Render the correct theme when using 'getPopupContainer'#41465afc163 merged 1 commit intoant-design:masterfrom
afc163 merged 1 commit intoant-design:masterfrom
Conversation
Contributor
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41465 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 610 610
Lines 10467 10467
Branches 2861 2861
=========================================
Hits 10467 10467
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
afc163
approved these changes
Mar 27, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ref #41423 (comment)
💡 Background and solution
当前如果在 Menu 组件中使用
getPopupContainer选中主菜单（getPopupContainer={(node) => node.parentNode}）时子菜单如果设置了 theme ，那么该 theme 将被主菜单 theme 覆盖，修改前后可见下图：修改前，主菜单 theme 为dark，子菜单 theme 为 light：
修改后
1、主菜单 theme 为 dark，子菜单 theme 为 light：
2、主菜单 theme 为 light，子菜单 theme 为 dark：
📝 Changelog
getPopupContainerto select the main menugetPopupContainer选择主菜单时子菜单主题被覆盖☑️ Self-Check before Merge