chore: fixed InternalTreeSelect's generic signature#41386
Merged
li-jia-nan merged 1 commit intoant-design:masterfrom Mar 22, 2023
Merged
chore: fixed InternalTreeSelect's generic signature#41386li-jia-nan merged 1 commit intoant-design:masterfrom
InternalTreeSelect's generic signature#41386li-jia-nan merged 1 commit intoant-design:masterfrom
Conversation
Contributor
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #41386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 610 610
Lines 10453 10453
Branches 2851 2851
=========================================
Hits 10453 10453
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
Mar 22, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declared signature doesn't match the one to which it is casted later on:
ant-design/components/tree-select/index.tsx
Lines 251 to 258 in f7fd474
This should be a type error but currently, it's accidentally swallowed by TS. Notice how the problem is reported in this TS playground and how it goes away when you include the commented out property.