Skip to content

fix: Tabs border should not overlay with other border#41381

Merged
MadCcc merged 2 commits intomasterfrom
fix/tabs-border
Mar 22, 2023
Merged

fix: Tabs border should not overlay with other border#41381
MadCcc merged 2 commits intomasterfrom
fix/tabs-border

Conversation

@MadCcc
Copy link
Copy Markdown
Member

@MadCcc MadCcc commented Mar 21, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs that underline should not overlap with other border.
🇨🇳 Chinese 修复 Tabs 组件下边框与其他边框叠加的样式问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 21, 2023

Comment thread components/tabs/style/index.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 21, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.56 KB (+2 B 🔺)
./dist/antd-with-locales.min.js 431.44 KB (+1 B 🔺)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f7fd474) 100.00% compared to head (15ba659) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41381   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10453     10453           
  Branches      2851      2851           
=========================================
  Hits         10453     10453           
Impacted Files Coverage Δ
components/tabs/style/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread components/tabs/style/index.ts
@afc163
Copy link
Copy Markdown
Member

afc163 commented Mar 22, 2023

截个图?

@MadCcc
Copy link
Copy Markdown
Member Author

MadCcc commented Mar 22, 2023

截个图?

预期变化都在 argos 里

@MadCcc MadCcc merged commit f9c3143 into master Mar 22, 2023
@MadCcc MadCcc deleted the fix/tabs-border branch March 22, 2023 03:24
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Tabs border should not overlay with other border

* fix: more border
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Tabs border should not overlay with other border

* fix: more border
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants