Skip to content

chore: Select like component always showArrow#41028

Merged
MadCcc merged 7 commits intofeaturefrom
select-arrow
Mar 5, 2023
Merged

chore: Select like component always showArrow#41028
MadCcc merged 7 commits intofeaturefrom
select-arrow

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Mar 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust Select, TreeSelect, Cascader always show the arrow by default when multiple.
🇨🇳 Chinese 调整 Select, TreeSelect, Cascader 在多选时总是默认显示下拉箭头。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2023

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.35 KB (-13 B 🔽)
./dist/antd-with-locales.min.js 431.29 KB (-21 B 🔽)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (9d546ed) 100.00% compared to head (7938052) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           feature    #41028    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          608       610     +2     
  Lines        10401     10615   +214     
  Branches      2831      2928    +97     
==========================================
+ Hits         10401     10615   +214     
Impacted Files Coverage Δ
components/auto-complete/index.tsx 100.00% <ø> (ø)
components/cascader/index.tsx 100.00% <100.00%> (ø)
components/select/index.tsx 100.00% <100.00%> (ø)
components/select/useShowArrow.ts 100.00% <100.00%> (ø)
components/tree-select/index.tsx 100.00% <100.00%> (ø)
components/popover/index.tsx 100.00% <0.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (ø)
components/table/style/size.ts 100.00% <0.00%> (ø)
components/table/style/index.ts 100.00% <0.00%> (ø)
components/table/InternalTable.tsx 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 6c32399 into feature Mar 5, 2023
@MadCcc MadCcc deleted the select-arrow branch March 5, 2023 15:29
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* chore: always showArrow

* test: update snapshot

* fix: autoComplete arrow logic

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* chore: always showArrow

* test: update snapshot

* fix: autoComplete arrow logic

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* chore: always showArrow

* test: update snapshot

* fix: autoComplete arrow logic

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants