Skip to content

feat: tooltip support arrow.pointAtCenter#40989

Merged
MadCcc merged 7 commits intofeaturefrom
feat/add-arrow-pointAtCenter
Mar 5, 2023
Merged

feat: tooltip support arrow.pointAtCenter#40989
MadCcc merged 7 commits intofeaturefrom
feat/add-arrow-pointAtCenter

Conversation

@MadCcc
Copy link
Copy Markdown
Member

@MadCcc MadCcc commented Mar 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#40983 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Tooltip support arrow.pointAtCenter and deprecate arrow.arrowPointAtCenter
🇨🇳 Chinese Tooltip 组件新增 arrow.pointAtCenter, 废弃 arrow.arrowPointAtCenter

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2023

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.24 KB (-33 B 🔽)
./dist/antd-with-locales.min.js 431.18 KB (-41 B 🔽)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (9d546ed) 100.00% compared to head (bdde69d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #40989   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          608       608           
  Lines        10401     10404    +3     
  Branches      2831      2831           
=========================================
+ Hits         10401     10404    +3     
Impacted Files Coverage Δ
components/popover/index.tsx 100.00% <ø> (ø)
components/tooltip/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Copy Markdown
Member

afc163 commented Mar 2, 2023

ci 没过

@MadCcc MadCcc merged commit 8ae56f2 into feature Mar 5, 2023
@MadCcc MadCcc deleted the feat/add-arrow-pointAtCenter branch March 5, 2023 09:51
@MadCcc MadCcc mentioned this pull request Mar 5, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* feat: tooltip support arrow.pointAtCenter

* test: rm only

* fix: Popover

* fix: rm popover arrow logic

* test: update test

* chore: skip debug demo test
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: tooltip support arrow.pointAtCenter

* test: rm only

* fix: Popover

* fix: rm popover arrow logic

* test: update test

* chore: skip debug demo test
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: tooltip support arrow.pointAtCenter

* test: rm only

* fix: Popover

* fix: rm popover arrow logic

* test: update test

* chore: skip debug demo test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants