Skip to content

refactoring: use hook replace LocaleReceiver#40870

Merged
li-jia-nan merged 8 commits intomasterfrom
useLocaleReceiver
Feb 22, 2023
Merged

refactoring: use hook replace LocaleReceiver#40870
li-jia-nan merged 8 commits intomasterfrom
useLocaleReceiver

Conversation

@li-jia-nan
Copy link
Copy Markdown
Member

@li-jia-nan li-jia-nan commented Feb 22, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactoring: use hook replace LocaleReceiver
🇨🇳 Chinese refactoring: 使用 useLocale 代替 LocaleReceiver 组件，删除 LocaleReceiver 组件

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2023 •
edited
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 368.13 KB (-169 B 🔽)
./dist/antd-with-locales.min.js 424.34 KB (-200 B 🔽)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f9218c6) compared to base (f9a38af).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #40870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          606       606           
  Lines        10298     10372   +74     
  Branches      2791      2833   +42     
=========================================
+ Hits         10298     10372   +74
Impacted Files Coverage Δ
components/calendar/generateCalendar.tsx 100.00% <100.00%> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/empty/index.tsx 100.00% <100.00%> (ø)
components/form/FormItemLabel.tsx 100.00% <100.00%> (ø)
components/locale/useLocale.ts 100.00% <100.00%> (ø)
components/modal/ConfirmDialog.tsx 100.00% <100.00%> (ø)
components/modal/Modal.tsx 100.00% <100.00%> (ø)
components/modal/PurePanel.tsx 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan changed the title chore: rename useLocaleReceiver => useLocale refactoring: use hook replace LocaleReceiver Feb 22, 2023
li-jia-nan
li-jia-nan commented Feb 22, 2023
View reviewed changes
Comment thread components/modal/PurePanel.tsx
MadCcc
MadCcc reviewed Feb 22, 2023
View reviewed changes
Comment thread components/locale/LocaleReceiver.ts Outdated
@li-jia-nan li-jia-nan requested a review from MadCcc February 22, 2023 09:56
@MadCcc
Copy link
Copy Markdown
Member

MadCcc commented Feb 22, 2023

少了 200B，舒服了

@MadCcc
Copy link
Copy Markdown
Member

MadCcc commented Feb 22, 2023

Changelog 都写一下

@li-jia-nan
Copy link
Copy Markdown
Member Author

li-jia-nan commented Feb 22, 2023

为啥会少这么多，两个方法内部实现都基本一样

@yoyo837
Copy link
Copy Markdown
Contributor

yoyo837 commented Feb 22, 2023

多个文件的相同导入路径缩短了

@li-jia-nan
Copy link
Copy Markdown
Member Author

li-jia-nan commented Feb 22, 2023

Changelog 都写一下

done~

@li-jia-nan li-jia-nan merged commit 288b10b into master Feb 22, 2023
@li-jia-nan li-jia-nan deleted the useLocaleReceiver branch February 22, 2023 10:18
@li-jia-nan li-jia-nan mentioned this pull request Feb 24, 2023
Merged
20 tasks
@chenshuai2144 chenshuai2144 mentioned this pull request Feb 27, 2023
Merged
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
@li-jia-nan @RedJue
refactoring: use hook replace LocaleReceiver (ant-design#40870)
c71557c 
* chore: rename useLocaleReceiver => useLocale

* refactoring: use hook replace LocaleReceiver

* fix

* update snap

* fix

* update snap

* fix

* rename
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@li-jia-nan @RedJue
refactoring: use hook replace LocaleReceiver (ant-design#40870)
194ea35 
* chore: rename useLocaleReceiver => useLocale

* refactoring: use hook replace LocaleReceiver

* fix

* update snap

* fix

* update snap

* fix

* rename
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@li-jia-nan @RedJue
refactoring: use hook replace LocaleReceiver (ant-design#40870)
e6e2f7a 
* chore: rename useLocaleReceiver => useLocale

* refactoring: use hook replace LocaleReceiver

* fix

* update snap

* fix

* update snap

* fix

* rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadCcc MadCcc MadCcc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@li-jia-nan @MadCcc @yoyo837