Skip to content

feat: Image support flip function and fix fallback#40660

Merged
afc163 merged 3 commits intofeaturefrom
fix/image-fallback
Feb 9, 2023
Merged

feat: Image support flip function and fix fallback#40660
afc163 merged 3 commits intofeaturefrom
fix/image-fallback

Conversation

@afc163
Copy link
Copy Markdown
Member

@afc163 afc163 commented Feb 9, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #40555

💡 Background and solution

react-component/image#187
react-component/image#186

Fixed now: https://preview-40660-ant-design.surge.sh/~demos/components-image-demo-fallback

📝 Changelog

Language Changelog
🇺🇸 English Image support flip function in preview mode.
Fix Image fallback when used in ssr.
🇨🇳 Chinese Image 预览新增图片翻转功能。
修复 Image fallback 在 ssr 下失效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2023 •
edited
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2023 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 368.27 KB (+447 B 🔺)
./dist/antd-with-locales.min.js 424.19 KB (+456 B 🔺)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6b76411) compared to base (31cbbce).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #40660   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          606       606           
  Lines        10287     10287           
  Branches      2789      2789           
=========================================
  Hits         10287     10287
Impacted Files Coverage Δ
components/image/PreviewGroup.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 force-pushed the fix/image-fallback branch from 66a88b8 to a093936 Compare February 9, 2023 11:15
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 9, 2023 •
edited
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: core-js@3.27.2, esbuild@0.16.17, puppeteer@19.6.3

Powered by socket.dev

@afc163 afc163 changed the title chore: add console.log to image fallback demo fix: Image fallback in ssr Feb 9, 2023
@afc163 afc163 changed the base branch from master to feature February 9, 2023 12:07
@afc163 afc163 changed the title fix: Image fallback in ssr feat: Image support filp function and fix fallback Feb 9, 2023
@afc163 afc163 marked this pull request as ready for review February 9, 2023 12:17
@afc163
Copy link
Copy Markdown
Member Author

afc163 commented Feb 9, 2023 

@SocketSecurity ignore core-js@3.27.2
@SocketSecurity ignore esbuild@0.16.17
@SocketSecurity ignore puppeteer@19.6.3

@afc163 afc163 changed the title feat: Image support filp function and fix fallback feat: Image support flip function and fix fallback Feb 9, 2023
@afc163 afc163 merged commit e11ef76 into feature Feb 9, 2023
@afc163 afc163 deleted the fix/image-fallback branch February 9, 2023 16:12
@yoyo837 yoyo837 mentioned this pull request Feb 16, 2023
Closed
@MadCcc MadCcc mentioned this pull request Mar 5, 2023
Merged
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
@afc163 @RedJue
feat: Image support flip function and fix fallback (ant-design#40660)
1ac4448 
* bump rc-image 5.15.1

* add flix support

* chore: update snapshot
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@afc163 @RedJue
feat: Image support flip function and fix fallback (ant-design#40660)
0191b0c 
* bump rc-image 5.15.1

* add flix support

* chore: update snapshot
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@afc163 @RedJue
feat: Image support flip function and fix fallback (ant-design#40660)
86b66dd 
* bump rc-image 5.15.1

* add flix support

* chore: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afc163 @zombieJ