Skip to content

refactor: Tooltip support auto arrow & auto shift#40632

Merged
zombieJ merged 33 commits intofeaturefrom
tooltip
Feb 15, 2023
Merged

refactor: Tooltip support auto arrow & auto shift#40632
zombieJ merged 33 commits intofeaturefrom
tooltip

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Feb 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tooltip support auto arrow position & adjust position if possible. destroyTooltipOnHide.keepParent is deprecated since it will be always auto destroy unnecessary container now.
🇨🇳 Chinese Tooltip 现在自动调整自身以及箭头位置以更好的展示。同时废弃 destroyTooltipOnHide.keepParent,现在总是会自动销毁不需要的容器。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2023

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 8, 2023

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 372.79 KB (+4.41 KB 🔺)
./dist/antd-with-locales.min.js 429.07 KB (+4.52 KB 🔺)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (adedc3a) compared to base (185c276).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #40632   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          607       608    +1     
  Lines        10298     10346   +48     
  Branches      2790      2805   +15     
=========================================
+ Hits         10298     10346   +48     
Impacted Files Coverage Δ
components/dropdown/dropdown.tsx 100.00% <ø> (ø)
components/popover/PurePanel.tsx 100.00% <ø> (ø)
components/tooltip/PurePanel.tsx 100.00% <ø> (ø)
components/tooltip/__tests__/util.ts 100.00% <ø> (ø)
components/tooltip/index.tsx 100.00% <ø> (ø)
components/tooltip/style/index.ts 100.00% <ø> (ø)
components/tour/index.tsx 100.00% <ø> (ø)
components/_util/placements.ts 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ marked this pull request as ready for review February 14, 2023 15:47
@zombieJ zombieJ merged commit 86b5c50 into feature Feb 15, 2023
@zombieJ zombieJ deleted the tooltip branch February 15, 2023 02:21
@afc163
Copy link
Copy Markdown
Member

afc163 commented Feb 15, 2023

还是需要这个演示:div ,带横纵向滚动条,不加 getPopupContainer。

预期效果,滚动时 tooltip 跟随 trigger,并且不被 div 遮挡,也不 adjust 位置

@yoyo837
Copy link
Copy Markdown
Contributor

yoyo837 commented Feb 22, 2023

@rc-component/trigger最终是要完全代替rc-trigger的吧?

@MadCcc MadCcc mentioned this pull request Mar 5, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* chore: adjust doc

* chore: simplify arrow offset

* chore: auto adjust shift

* docs: adjust demo

* chore: update snapshot

* chore: provide ref

* test: prepare

* chore: update deps

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: update snapshot

* fix: missing pure render

* fix: Popover pure panel

* test: update snapshot

* test: update tour snapshot

* chore: bump trigger ver

* test: fix render ssr logic

* test: skip unnecessary case

* test: fix test case

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: fix test case

* test: fix test case

* chore: clean up useless warning

* test: add check for placement

* chore: ignore default
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* chore: adjust doc

* chore: simplify arrow offset

* chore: auto adjust shift

* docs: adjust demo

* chore: update snapshot

* chore: provide ref

* test: prepare

* chore: update deps

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: update snapshot

* fix: missing pure render

* fix: Popover pure panel

* test: update snapshot

* test: update tour snapshot

* chore: bump trigger ver

* test: fix render ssr logic

* test: skip unnecessary case

* test: fix test case

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: fix test case

* test: fix test case

* chore: clean up useless warning

* test: add check for placement

* chore: ignore default
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* chore: adjust doc

* chore: simplify arrow offset

* chore: auto adjust shift

* docs: adjust demo

* chore: update snapshot

* chore: provide ref

* test: prepare

* chore: update deps

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: fix part test

* test: update snapshot

* fix: missing pure render

* fix: Popover pure panel

* test: update snapshot

* test: update tour snapshot

* chore: bump trigger ver

* test: fix render ssr logic

* test: skip unnecessary case

* test: fix test case

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: update snapshot

* test: fix test case

* test: fix test case

* chore: clean up useless warning

* test: add check for placement

* chore: ignore default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants