fix(material/chips): remove tab-index attribute from mat-chip host#29436
Merged
amysorto merged 6 commits intoangular:mainfrom Jul 31, 2024
Merged
fix(material/chips): remove tab-index attribute from mat-chip host#29436amysorto merged 6 commits intoangular:mainfrom
amysorto merged 6 commits intoangular:mainfrom
Conversation
added role presentation to mat-chip host so that mobile SR users do not have to double swipe to traverse chip fixes b/286286473
|
Deployed dev-app for 48f808c to: https://ng-dev-previews-comp--pr-angular-components-29436-dev-zgl7safa.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
e61b849 to
4d4b33b
Compare
add aria-hidden to host mat-chip so Talkback ignores element fixes b/286286473
remove tabindex fixes b/286286473
update api signature fixes b/286286473
fix lint issue fixes b/286286473
remove aria hidden fixes b/286286473
andrewseguin
approved these changes
Jul 31, 2024
amysorto
pushed a commit
that referenced
this pull request
Jul 31, 2024
…29436) * fix(material/chips): added role presentation to mat-chip host added role presentation to mat-chip host so that mobile SR users do not have to double swipe to traverse chip fixes b/286286473 * fix(material/chips): add aria-hidden add aria-hidden to host mat-chip so Talkback ignores element fixes b/286286473 * fix(material/chips): remove tabindex remove tabindex fixes b/286286473 * fix(material/chips): update api signature update api signature fixes b/286286473 * fix(material/chips): fix lint issue fix lint issue fixes b/286286473 * fix(material/chips): remove aria hidden remove aria hidden fixes b/286286473 (cherry picked from commit 5403b2b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove tabindex attribute from mat-chip as this makes the mat-chip element focusable for mobile screen readers (see YAQS link below). Having tabindex=-1 causes mobile screen readers to focus on the chip twice. removing makes it to where user only needs to swipe once to get the content of the chip.
https://yaqs.corp.google.com/eng/q/4811580888973312?ved=0CAAQ_rQKahcKEwiw_YGl9a6HAxUAAAAAHQAAAAAQHA
Before: https://screencast.googleplex.com/cast/NjAzNzgyNzIyMDQwNjI3MnwyMDVjMjkyZi02Mw
After: https://screencast.googleplex.com/cast/NTQxMzQ2MzM5NTQwMTcyOHw3NThhZjdlNi1mOQ
fixes b/286286473