Skip to content

feat(material/formfield): Add mdc-label class to <label> #26851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 1 commit into from
Mar 29, 2023
Merged

feat(material/formfield): Add mdc-label class to <label> #26851

crisbeto merged 1 commit into from
Mar 29, 2023

Conversation

@kvizcarra
Copy link
Contributor

@kvizcarra kvizcarra commented Mar 28, 2023

This is added to prevent a bug with the upcoming Theming API for Form Field.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 28, 2023
@kvizcarra
feat(material/formfield): Add mdc-label class to <label>
54a3bf6 
This is added to prevent a bug with the upcoming Theming API for Form Field.
@kvizcarra kvizcarra force-pushed the form-field-mdc-label branch from 199944b to 54a3bf6 Compare March 28, 2023 23:22
@kvizcarra kvizcarra changed the title feat(formfield): Add mdc-label class to <label> feat(material/formfield): Add mdc-label class to <label> Mar 28, 2023
crisbeto
crisbeto approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Mar 29, 2023
@crisbeto crisbeto merged commit a9b6135 into angular:main Mar 29, 2023
@kvizcarra kvizcarra deleted the form-field-mdc-label branch March 29, 2023 16:45
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 3, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvizcarra @crisbeto