Skip to content

fix(core): afterNextRender hooks return that callback value. #57031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(core): afterNextRender hooks return that callback value. #57031

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jul 17, 2024 •
edited
Loading

afterRender was working fine but afterNextRender wasn't

@pullapprove pullapprove bot requested a review from atscott July 17, 2024 21:13
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2024
@JeanMeche JeanMeche mentioned this pull request Jul 17, 2024
Closed
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 17, 2024
@JeanMeche
fix(core): afterNextRender hooks return that callback value.
39a8b40 
`afterRender` was working fine but `afterNextRender` wasn't
@JeanMeche JeanMeche force-pushed the fix/afterNextRender branch from 6819a43 to 39a8b40 Compare July 17, 2024 21:35
@angular-robot angular-robot bot requested a review from atscott July 17, 2024 21:35
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jul 19, 2024
@atscott
Copy link
Contributor

atscott commented Jul 19, 2024

This PR was merged into the repository by commit 7d4b2d2.

The changes were merged into the following branches: main, 18.1.x

atscott pushed a commit that referenced this pull request Jul 19, 2024
@JeanMeche @atscott
fix(core): afterNextRender hooks return that callback value. (#57031)
9e52c1c 
`afterRender` was working fine but `afterNextRender` wasn't

PR Close #57031
@atscott atscott closed this in 7d4b2d2 Jul 19, 2024
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
@JeanMeche @vladboisa
fix(core): afterNextRender hooks return that callback value. (angul…
b85329f 
…ar#57031)

`afterRender` was working fine but `afterNextRender` wasn't

PR Close angular#57031
@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 19, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@JeanMeche @atscott