fix(compiler): JIT mode incorrectly interpreting host directive configuration in partial compilation #57002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration in partial compilation Fixes that the runtime implementation of `ɵɵngDeclareDirective` was interpreting the `hostDirectives` mapping incorrectly. Instead of treating the inputs/outputs as `['binding', 'alias']` arrays, it was parsing them as `['binding: alias']`. This was leading to runtime errors if a user is consuming a partially-compiled library in JIT mode. Fixes angular#54096.
crisbeto
commented
Jul 16, 2024
| }; | ||
| } | ||
|
|
||
| function convertHostDirectivesToMetadata( |
Member
Author
There was a problem hiding this comment.
I ended up inlining this function into the two call sites to avoid confusion in the future since we have two different representations of host directives depending on the compilation format.
alxhub
approved these changes
Jul 16, 2024
Contributor
|
This PR was merged into the repository by commit 9167fc8. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 16, 2024
…guration in partial compilation (#57002) Fixes that the runtime implementation of `ɵɵngDeclareDirective` was interpreting the `hostDirectives` mapping incorrectly. Instead of treating the inputs/outputs as `['binding', 'alias']` arrays, it was parsing them as `['binding: alias']`. This was leading to runtime errors if a user is consuming a partially-compiled library in JIT mode. Fixes #54096. PR Close #57002
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 16, 2024
…guration in partial compilation (angular#57002) Fixes that the runtime implementation of `ɵɵngDeclareDirective` was interpreting the `hostDirectives` mapping incorrectly. Instead of treating the inputs/outputs as `['binding', 'alias']` arrays, it was parsing them as `['binding: alias']`. This was leading to runtime errors if a user is consuming a partially-compiled library in JIT mode. Fixes angular#54096. PR Close angular#57002
atscott
pushed a commit
that referenced
this pull request
Jul 16, 2024
…guration in partial compilation (#57002) (#57003) Fixes that the runtime implementation of `ɵɵngDeclareDirective` was interpreting the `hostDirectives` mapping incorrectly. Instead of treating the inputs/outputs as `['binding', 'alias']` arrays, it was parsing them as `['binding: alias']`. This was leading to runtime errors if a user is consuming a partially-compiled library in JIT mode. Fixes #54096. PR Close #57002 PR Close #57003
This was referenced Jul 25, 2024
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the runtime implementation of
ɵɵngDeclareDirectivewas interpreting thehostDirectivesmapping incorrectly. Instead of treating the inputs/outputs as['binding', 'alias']arrays, it was parsing them as['binding: alias']. This was leading to runtime errors if a user is consuming a partially-compiled library in JIT mode.Fixes #54096.