fix(migrations): fix common module removal #56968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case that common module is removed on a second run of the migration. We were not looking at block parameters for common module usage.
AndrewKushnir
approved these changes
Jul 12, 2024
Contributor
|
This PR was merged into the repository by commit 0ea6a4a. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 15, 2024
This fixes the case that common module is removed on a second run of the migration. We were not looking at block parameters for common module usage. PR Close #56968
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case that common module is removed on a second run of the migration. We were not looking at block parameters for common module usage.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?